Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOBC を想定した機能を有効化するためのビルドオプションを追加 #306

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

meltingrabbit
Copy link
Member

@meltingrabbit meltingrabbit commented Feb 5, 2024

概要

#305 のための準備.
デフォルト実装を core で提供するとき,MOBC か sub OBC かのどちらを意図してるコードかを切り替えるために用いる

あわせて,ビルドオプションのドキュメントも多少整備した.

Issue

NA

影響範囲

この PR ではこのオプションを利用するコードは追加されてないため,なし

備考

@meltingrabbit meltingrabbit self-assigned this Feb 5, 2024
@meltingrabbit meltingrabbit added enhancement New feature or request priority::medium priority medium labels Feb 5, 2024
@meltingrabbit meltingrabbit marked this pull request as ready for review February 5, 2024 01:52
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@meltingrabbit meltingrabbit force-pushed the feature/add_mobc_subobc_build_option branch from bfd3041 to 49651fe Compare February 13, 2024 04:21
@meltingrabbit meltingrabbit added the documentation Improvements or additions to documentation label Feb 13, 2024
@meltingrabbit meltingrabbit force-pushed the feature/add_mobc_subobc_build_option branch 3 times, most recently from 7ef6111 to 0b8e8e9 Compare March 13, 2024 05:45
@meltingrabbit meltingrabbit mentioned this pull request Mar 13, 2024
6 tasks
@meltingrabbit meltingrabbit force-pushed the feature/add_mobc_subobc_build_option branch from 0b8e8e9 to 9a7f6bf Compare March 28, 2024 05:42
CMakeLists.txt Outdated Show resolved Hide resolved


#### `C2A_USE_ALL_CORE_TEST_APPS`
`ON` にすることで,全ての [Core Test Application](/applications/test_app/) をビルドする.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core hoge は対象が一意に定まらないので,あくまで c2a-core と表記したい

Suggested change
`ON` にすることで,全ての [Core Test Application](/applications/test_app/) をビルドする.
`ON` にすることで,全ての [c2a-core Test Application](/applications/test_app/) をビルドする.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このドキュメントそんなに要りますかね.無くていいというつもりは無いけれど,これぐらいの何も言ってなさなら CMakeLists.txt の先頭を見たり,そこにコメントがあったりする方が読む方も書く方も速いと思うんですが.メンテしにくいし.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あと単にこの PR のスコープ外に思える

CMakeLists.txt Show resolved Hide resolved
@meltingrabbit
Copy link
Member Author

@sksat ドキュメントはPR分離します.

ドキュメントの必要性ですが,c2a userのみを使うような人には,これはあったほうがいいと思います.たとえば. C2A_USE_ALL_CORE_APPS とかはこれまで死ぬほど口頭に説明してるので,ドキュメント需要しかないです.
ドキュメントはよく使うものだけ列挙+簡単なコメントをいれておいて,詳細や全容は CMakeLists.txt に誘導すればいいと思ってます.

@meltingrabbit meltingrabbit force-pushed the feature/add_mobc_subobc_build_option branch from 4ed678d to 4130dff Compare March 29, 2024 03:48
@meltingrabbit meltingrabbit force-pushed the feature/add_mobc_subobc_build_option branch from 4130dff to a66034e Compare March 29, 2024 04:30
@meltingrabbit
Copy link
Member Author

@sksat docsをのぞきました(rebaseした)

@meltingrabbit meltingrabbit merged commit 4472ef1 into main Mar 29, 2024
37 checks passed
@meltingrabbit meltingrabbit deleted the feature/add_mobc_subobc_build_option branch March 29, 2024 04:40
@sksat sksat changed the title MOBC やsub OBC を想定したコードをビルド対象に加えるためのビルドオプションを追加 MOBC を想定した機能を有効化するためのビルドオプションを追加 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request priority::medium priority medium
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants